Revert change of building everything-heads to musl-cross-make (musl-cross-make all but coreboot) #929
Conversation
|
(Intention here was to test building #709, untested, while build successful) You see any problem in merging this? |
* Add vboot support to supported Lenovo boards * Didn't add config that wouldn't build (non ME stripped versions) Signed-off-by: Patrick Rudolph <[email protected]>
…g as error inside of coreboot module
…t toolchain for its compilation - remove coreboot patches to build coreboot against musl-cross-make directly - musl-cross-make only responsible to build the rest of the modules
tlaurion
force-pushed
the
9element_vboot_rebased
branch
from
4012895
to
1aaf4cc
Compare
|
Tested xx30-hotp-maximized rom : functional |
|
I'll try to test this tomorrow along with the busybox bump |
|
any reason the lenovo vboot stuff is being pulled in here? Don't see how that that shouldn't be a separate PR |
|
built/booted a Librem Mini v2 (w/coreboot-4.13 and busybox 1.3.1) using coreboot toolchain to build coreboot, no issues |
It is in another PR. Was just not building outside of having CircleCI and the present changed. No sure how to merge this since that PR #562 is totally stalled. |
|
@MrChromebox do you see other optimizations? I remember vauely that this is a derivative of your proposition for 4.12 where force commits made the history vanished. I want this to be a transition to #927 |
|
@tlaurion IMO, this PR should be just the changes to the coreboot module itself, removing the corss-compiler patches, and adjusting CI dependencies. Adding vboot support (configs and CI) should be separate. The CI changes to the KGPE-D16 should be separate as well. I'm not sure how 562 is relevant here, since it was created before coreboot's measured boot (which we now use) was separated from vboot. This PR certainly is a start towards 927, but it has too many unrelated things tacked on. I would absolutely force-push an update to the branch which includes either a single commit, or one for the module/patch changes, plus one for the CI changes. |
|
Replaced by #938 |
Partly fixes #927, where midterm-longterm is to move away of musl-cross-make and build with guix-buildstack, where #927 should be invested.